Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert jobs to rbenv #445

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Convert jobs to rbenv #445

merged 1 commit into from
Apr 22, 2024

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Apr 21, 2024

No description provided.

@ehelms ehelms force-pushed the convert-to-rbenv branch from d2b38d3 to 0d81cbb Compare April 21, 2024 18:43
evgeni
evgeni requested changes Apr 22, 2024
View reviewed changes
Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the breakage to the existing two jobs already using rbenv

theforeman.org/pipelines/lib/rbenv.groovy Show resolved Hide resolved
@ehelms ehelms force-pushed the convert-to-rbenv branch from 0d81cbb to 424eaf1 Compare April 22, 2024 11:54
@ehelms ehelms merged commit 81ff2fb into theforeman:master Apr 22, 2024
2 checks passed
@evgeni evgeni mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeni evgeni evgeni approved these changes

Assignees
No one assigned
Labels
Waiting on contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehelms @evgeni